Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Environment Configuration and Dependencies #354

Merged
merged 8 commits into from
May 30, 2023

Conversation

sreekarreddydfci
Copy link
Collaborator

  1. Excluded Python version and python-spams as dependencies in the environment.yml file.
  2. Added python-spams dependency outside the environment.yml file.
  3. Implemented mamba for environment setup.

Excluded python version as dependency
Exclude python-spams dependency
Replaced conda with mamba
Using setup-micromamba to setup environment, installing python-spams.
Added micromamba to setup environment
rollback to mamba, couldn't resolve openjdk 8 when using micromamba
Update environment.yml and test-conda.yml
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2023

Codecov Report

Merging #354 (b630aec) into master (9b6ed8e) will increase coverage by 0.07%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #354      +/-   ##
==========================================
+ Coverage   86.37%   86.45%   +0.07%     
==========================================
  Files          27       27              
  Lines        2503     2503              
==========================================
+ Hits         2162     2164       +2     
+ Misses        341      339       -2     
Impacted Files Coverage Δ
pathml/_version.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@jacob-rosenthal jacob-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tests pass and actions run much faster now.
No changes to the code base so ok to merge to master I think in this case, to fix the broken test workflows

@jacob-rosenthal jacob-rosenthal merged commit 572af26 into Dana-Farber-AIOS:master May 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants