Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class MultiparametricSlide to preprocessing/wsi.py #3

Merged

Conversation

ryanccarelli
Copy link
Contributor

Added support for multiparametric images of all proprietary formats with class MultiparametricSlide.
Depends on python-bioformats which uses javabridge to access java bioformats library. Bioformats is maintained by OME and used in multiple large projects (ImageJ, CellProfiler, etc.)
Installation of new dependencies is not required. User is prompted to install dependencies when they call MultiparametricSlide.
Added and passed tests in test_wsi.py.

@@ -397,7 +397,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.7.7"
"version": "3.8.5"
}
},
"nbformat": 4,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably find a way to automatically exclude jupyter notebook metadata from commits/diffs...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix that before merging

setup.py Outdated Show resolved Hide resolved
@ryanccarelli ryanccarelli merged commit 902f8e8 into Dana-Farber-AIOS:master Oct 8, 2020
@ryanccarelli ryanccarelli deleted the add_wsi_multiparametric branch October 8, 2020 00:31
@jacob-rosenthal
Copy link
Collaborator

We need to also add this new class to the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants