Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine roll-y once. #4

Merged
merged 1 commit into from
Jan 15, 2014
Merged

Conversation

bjlittle
Copy link

Determine whether to roll once rather than once per instance.

@DPeterK
Copy link
Owner

DPeterK commented Jan 14, 2014

Does this actually hit the original question? Doing this surely still means that each time Linear1dExtrapolator is called so is interp1d_rolls_y so the value of self.roll_y is still re-evaluated each time?

@ajdawson
Copy link

_interp1d_rolls_y is evaluated once to initialize a class variable, it will be reused for every class instance.

@DPeterK
Copy link
Owner

DPeterK commented Jan 15, 2014

Learn something new every day... Thanks @ajdawson!

@DPeterK DPeterK merged this pull request into DPeterK:scipy_0-13-2_interpolate Jan 15, 2014
@bjlittle
Copy link
Author

Great, thanks @dkillick!

@bjlittle bjlittle deleted the roll branch January 15, 2014 10:20
DPeterK pushed a commit that referenced this pull request Oct 21, 2015
Add tests for _xy_range typo fix
DPeterK pushed a commit that referenced this pull request May 2, 2017
* Fix import order.

* Review actions.
DPeterK pushed a commit that referenced this pull request Jun 28, 2017
* Fix import order.

* Review actions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants