Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't install service files instead mention to user how to do this themselves #2346

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

vmcj
Copy link
Member

@vmcj vmcj commented Feb 25, 2024

This now implements what was mentioned in the linked issue, this was updated from before.

Closes: #2086

@thijskh
Copy link
Member

thijskh commented Feb 28, 2024

I’m all for making docs match reality, but seems to complicatie the instructions and increase mental load. What is the relation with this idea to make the software less complex, instead of the instructions more complex?

@vmcj
Copy link
Member Author

vmcj commented Feb 28, 2024

I’m all for making docs match reality, but seems to complicatie the instructions and increase mental load. What is the relation with this idea to make the software less complex, instead of the instructions more complex?

So you want to leave the documentation as is and mention it after the make install-judgehost step in code?

@thijskh
Copy link
Member

thijskh commented Feb 28, 2024

Yes, as I understand that this is Jaap’s suggestion in the linked issue

@eldering
Copy link
Member

Yes, as I understand that this is Jaap’s suggestion in the linked issue

And also remove the installation of service files for the FHS install.

@vmcj vmcj changed the title Clarify in docs that service files are not default installed (in non-FHS). Don't install service files instead mention to user how to do this themselves Jun 26, 2024
@vmcj vmcj requested a review from a team June 26, 2024 18:44
Makefile Outdated Show resolved Hide resolved
doc/manual/install-judgehost.rst Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@vmcj vmcj requested a review from eldering July 3, 2024 19:41
For FHS install the chosen option is most likely incorrect and in case
someone uses a prefix the files would most of the time still need to be
installed outside of that prefix. The same method as
for the webserver files will be used, so present the option to copy them
yourself as sysadmin on the machine both in the Makefile and in the
documentation.

Co-authored-by: Jaap Eldering <[email protected]>
@vmcj vmcj added this pull request to the merge queue Jul 27, 2024
Merged via the queue into DOMjudge:main with commit ec7ca6c Jul 27, 2024
26 checks passed
@vmcj vmcj deleted the service_files_non_fhs branch July 27, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default configure does not install service files for judgedaemon, docs do mention those.
3 participants