[Feat/week8] clean architecture #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
λλ ν 리 [data-datasourceimpl-remote]
β¦oAndroidViewModel μ΄κΈ°ν
[chore] : rename
chanubc
added
βΒ [ADD]
sohyun127
approved these changes
Jan 3, 2024
Comment on lines
+16
to
+17
| private const val AUTH_BASE_URL = BuildConfig.AUTH_BASE_URL | ||
| private const val USER_BASE_URL = BuildConfig.USER_BASE_URL |
There was a problem hiding this comment.
λ€μ΄λ°μ΄ λκ°μλ° λ³μλ₯Ό μ μΈν΄μ€ μ΄μ κ° μμκΉμ??
Comment on lines
+11
to
+13
| override suspend fun getReqresList(page: Int): ResponseReqresDto { | ||
| return reqresService.getUserList(page) | ||
| } |
There was a problem hiding this comment.
Suggested change
| override suspend fun getReqresList(page: Int): ResponseReqresDto { | |
| return reqresService.getUserList(page) | |
| } | |
| override suspend fun getReqresList(page: Int): ResponseReqresDto = reqresService.getUserList(page) | |
μκΈ°λ μμλ ν΅μΌμ± μκ²!
| is LoginState.Error -> toast("λ‘κ·ΈμΈ μ€ν¨") | ||
| is LoginState.Loading -> toast("λ‘κ·ΈμΈ μ€") | ||
| is UiState.Error -> toast("λ‘κ·ΈμΈ μ€ν¨") | ||
| is UiState.Loading -> {} |
There was a problem hiding this comment.
Suggested change
| is UiState.Loading -> {} | |
| is UiState.Loading -> Unit |
μλ κ²λ μμ± κ°λ₯!
| Log.d("server", it.code().toString()) | ||
| authRepository.login(UserRequestEntity(id, password)) | ||
| .onSuccess { | ||
| _loginState.emit(UiState.Success(it)) |
There was a problem hiding this comment.
viewModelμμ λ°μ΄ν°λ₯Ό μμ°(emit)ν΄μ£Όμ μ΄μ κ° μμκΉμ?!
sohyun127
reviewed
Jan 4, 2024
| } | ||
| } | ||
|
|
||
| private fun observeSignUpState(userEntity: User) { | ||
| private fun observeSignUpState() { | ||
| lifecycleScope.launch { | ||
| viewModel.signUpState.collect { |
There was a problem hiding this comment.
κ·Έλ¦¬κ³ flowWithLifecycleμ λν΄μ 곡λΆν΄λ³΄λ©΄ μ’μ κ² κ°μμ!
(ννΈλ StateFlowλ lifecycleμ μλμΌλ‘ μ²λ¦¬νμ§ μμμ μλμΌλ‘ flowμ collect μ€μ§μμΌμ£Όμ΄μΌν΄μ!)
|
ν΄λ¦°μν€ν
μ³ μ 볡μ΅νκ³ κ°λλ€μ~~! νμ΄ν
~! |
m6z1
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
πππ΄π΄πΆπ¦π΄
πππ°π³π¬ ππ¦π΄π€π³πͺπ±π΅πͺπ°π―
π·ππ€π³π¦π¦π―π΄π©π°π΅
π¬ππ° ππ¦π·πͺπ¦πΈπ¦π³π΄
μνμ μ΄λ €μ€