Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix downloads #3098

Merged
merged 7 commits into from
Jan 28, 2022
Merged

Fix downloads #3098

merged 7 commits into from
Jan 28, 2022

Conversation

raycarrick-ed
Copy link
Contributor

Fixes #3074.

Addresses an issue when downloading a plan with a blank answer
Fixes an issue that was preventing an Org Admin from downloading their Org's plans as CSV if any plan had a nil owner
Fixes an issue downloading a plan as text

(Originally done by @briri but redone here to just have the needed change since master has changed so much since it was done)

briri and others added 7 commits November 30, 2021 14:24
@briri
fixed issues with a few edge-case errors for plan downloads in csv an…
ad52bfc 
…d text formats
@briri @raycarrick-ed
fixed issues with a few edge-case errors for plan downloads in csv an…
544e77b 
…d text formats
@raycarrick-ed
formatting changes
3d76ff1
@raycarrick-ed
trying to figure out brakeman error
27434b5
@raycarrick-ed
Fix brakeman sql injection
098b579 
Brake gives possible sql injection.
Not entirely sure what it's about byt guessing it's the sort_direction.
@raycarrick-ed
Rubocop fixes
0c17d14 
disable complexity warnings and change quotes to get rubocop happy.
@raycarrick-ed
renable rubocop
d9e26a6 
renable rubocop after end of method
@raycarrick-ed raycarrick-ed merged commit efc7dd1 into master Jan 28, 2022
@raycarrick-ed raycarrick-ed deleted the fix_downloads branch January 28, 2022 11:58
@briri briri mentioned this pull request Feb 14, 2022
Merged
@laurastandaert laurastandaert mentioned this pull request Feb 24, 2022
Closed
This was referenced Feb 6, 2024
Closed
Closed
Open
This was referenced Mar 19, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Various errors with downloads
2 participants
@raycarrick-ed @briri