Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to pass both horizontal and vertical FOV #982

Closed
wants to merge 1 commit into from

Conversation

fortminors
Copy link

blenderpy allows to set either cam.angle or both cam.angle_x and cam.angle_y. Source

It's quite handy to provide this option through blenderproc API

@cla-bot
Copy link

cla-bot bot commented Sep 26, 2023

For contributing to BlenderProc you need to sign our Contributor License Agreement. As an individual please sign CLA_individuals.pdf, as a company please sign CLA_entities.pdf and send it to [email protected]

@cornerfarmer
Copy link
Member

Hey @fortminors,

thanks a lot for the pull request, unfortunately this does not work as intended as blender does not allow setting angle_x and angle_y individually. Each time when setting angle_x/angle_y one is actually changing the focal length. So in your code, when setting angle_y, this would actually overwrite the changes you made to angle_x in the line before. See https://blender.stackexchange.com/a/300728

As blenders camera intrinsics are a bit weird its recommend to set them via our ´set_intrinsics_from_K_matrix()´ method

@fortminors fortminors closed this Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants