Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Popup should be able to open or close programtically #74

Closed
haavamoa opened this issue Dec 16, 2019 · 0 comments
Closed
Assignees
Labels
enhancement New feature or request in-progress When work is started
Projects

Comments

@haavamoa
Copy link
Member

haavamoa commented Dec 16, 2019

Summary

The consumer of the popup should be able to open or close the popup programticall. This can be achieved by using the attached property in the view, but it should also be able to do it by a bindable property.

API Changes

Concider adding a boolean IsOpen to the PopupBehaviour.

  • This should be bindable with mode : TwoWay
  • It should be set to true when the user clicks the view element that owns the behaviour, so our consumers can programtically know when the user has clicked it.
    -It should be set to false when the user closes the popup (either through clicking outside or by clicking a view with Popup.CloseOnClick.)
  • It should react to property changed and open / close the popup programtically.
@haavamoa haavamoa added the enhancement New feature or request label Dec 16, 2019
@haavamoa haavamoa changed the title [Enhancement] Popup should be able to open or close the popup programtically [Enhancement] Popup should be able to open or close programtically Dec 16, 2019
@Illedan Illedan added the in-progress When work is started label Jan 6, 2020
@Illedan Illedan self-assigned this Jan 6, 2020
Illedan added a commit that referenced this issue Jan 7, 2020
Illedan pushed a commit that referenced this issue Jan 8, 2020
* Added IsOpen to PopupBehavior

#74
@Illedan Illedan closed this as completed Jan 8, 2020
@haavamoa haavamoa added this to Done in Popup Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in-progress When work is started
Projects
No open projects
Popup
  
Done
Development

No branches or pull requests

2 participants