-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: report filter by id #144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please also update the README.md
with the the new help menu of the reporter.
done.
|
Please rebase from the main branch 🙏 |
did the rebase (and squash) and the last request |
Hey @tal66, |
Hey @tal66, |
strict :) |
Great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Due to branch protection rules, we require all commits to be signed. Can you please make sure to sign the commit? |
oops PR got closed 'cause i renamed the branch, due to a failing test (branch_prefix="^(feat|fix|refactor|chore|docs|test|library)/[a-z0-9._-]+$"). maybe you can reopen it |
For now, it is ok that the convention check is failing. However, It is important the commit will be signed. |
in my last commit i used |
Signed commits (using the GPG key) should look like this (contains the verified icon): ![]() You can read more here about commit signing. |
Signed-off-by: tal66 <[email protected]>
ok, created a temp key and now the commit appears to be verified (other repos don't require this) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great :)
I have requested one change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
closes #126