-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve file explorer #2
Conversation
@Cubxity what icons do you use for typstudio? |
Hi, thank you for contributing! Please mark the PR as draft if this is still W.I.P. Also, |
Material Icons. |
Ok i will remove yarn.lock |
Sidequestion: shouldn't you credit them? |
I think the pr is done. I also needed to add confirm dialog to ask before deletion. |
Hey, can you rebase and resolve the conflicts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just a few nitpicks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that creating directories and files should be hidden in a context menu. This removes clutter from the UI. Same goes for deletion.
@Cubxity Maybe show the icons only on hover? |
That sounds alright. |
Hi Guys! What is the status of this PR? Can you comment on it? Is it still in progress or just hanging? Cheers, |
I am busy right now so the pr is a hanged for now but I think I will return to this pr this weekend and finish it. |
Are you continuing this PR @OlshaMB? |
yes |
feat: Show icons only in hover, minor code tweaks
@caoimhebyrne Done |
Could you rebase/resolve conflicts? |
@OlshaMB are you planning on continuing to maintain this PR? If not, please let us know |
No, I am not planning, I am not interested in typst right now(waiting for html output) and there are too much changes to merge |
Ok, I will close the PR and open an issue for improving the file explorer. |
I want to improve file explorer usability
Roadmap