Hlord build update #202
Merged
Hlord build update #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this in a state I should start testing @crunchyheath ? |
|
Yes, this is in a state where you can build like you were before. I tried to make sure that the targets that existed before still exist now and have the same behavior. It just has more options, and the ability to override build options. |
pramsey
reviewed
Jan 23, 2024
| $(info Cleaning project...) | ||
| @rm -f $(PROGRAM) | ||
| @rm -rf docs/* | ||
| docker image prune --force | ||
| @docker image inspect $(CONTAINER):$(APPVERSION) >/dev/null 2>&1 && docker rmi -f $(CONTAINER):$(APPVERSION) $(CONTAINER):$(DATE) || echo -n "" |
There was a problem hiding this comment.
Is this working? My make clean is not removing the build artefacts or utility images.
pramsey
reviewed
Jan 23, 2024
| --label release="${APPVERSION}" \ | ||
| --label org.opencontainers.image.vendor="Crunchy Data" \ | ||
| --label os.version="7.7" \ | ||
| -t $(IMAGE_TAG) -t $(CONTAINER):$(DATE) . |
There was a problem hiding this comment.
DATE tags gets overwritten by whatever arch is the latest to be build (and presumably pushed, once I'm pushing to 'hub again).
pramsey
reviewed
Jan 23, 2024
| @rm -rf docs/* && cd hugo && hugo && cd .. | ||
|
|
||
| build: $(GOFILES) ## Build a local binary using APPVERSION parameter or CI as default | ||
| build: $(PROGRAM) ## Build a local binary using APPVERSION parameter |
There was a problem hiding this comment.
Local build only has capacity to build local arch. I think this is fine, as I'm getting cross compile elsewhere in CI...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first pass at making the Makefile and Dockerfile more flexible for users and to add initial multi-architectural support into the project.