Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] AutoUpdater doesn't overwrite old version of the app. #176

Closed
szero opened this issue Mar 9, 2023 · 3 comments
Closed

[BUG] AutoUpdater doesn't overwrite old version of the app. #176

szero opened this issue Mar 9, 2023 · 3 comments
Assignees
Labels
editor-bug A bug or defect found in an existing functionality.

Comments

@szero
Copy link

szero commented Mar 9, 2023

Describe the issue
Hey this is the issue guy again. When new version is detected by the updater, it gets downloaded to separate tf2-hud-editor directory instead of being extracted over already existing files so the path after update looks like this: ..\tf2-hud-editor\tf2-hud-editor and obviously after program restart we are continuously asked to update. Removing outer tf2-hud dir contents and replacing it with stuff that's in the inner folder concludes the update.

Desktop (please complete the following information):

  • OS: Win 10
  • App Version: any
@CriticalFlaw
Copy link
Owner

That sounds like the issue with the AutoUpdater dependency that the editor is using. I thought I had disabled the option to download from that pop-up and only allow the user to navigate to the release page. Will need to double check that...

Possibly find a better way of upgrading the editor as well.

@CriticalFlaw CriticalFlaw added the editor-bug A bug or defect found in an existing functionality. label Mar 9, 2023
@CriticalFlaw CriticalFlaw self-assigned this Mar 9, 2023
@CriticalFlaw CriticalFlaw changed the title [BUG] Hud editor updater doesn't overwrite old version of the program. [BUG] AutoUpdater doesn't overwrite old version of the app. Mar 17, 2023
@CriticalFlaw
Copy link
Owner

Started replacing AutoUpdaterNET for a manual method where we'll just check the current app version and compare it to the latest release tag on GitHub. Should be simpler and less error prone. 0d8b420

CriticalFlaw added a commit that referenced this issue Mar 24, 2023
@CriticalFlaw
Copy link
Owner

Fixed in f53da8e. This will be included in the next release. Thank you for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor-bug A bug or defect found in an existing functionality.
Projects
None yet
Development

No branches or pull requests

2 participants