-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - New review email #69
Open
magnus-thor
wants to merge
37
commits into
CraftAcademy:develop
Choose a base branch
from
magnus-thor:new_review_email
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
center text make h1 bold set line spacing between content
add logo at top of email setup config.action in test.rb to be able to send email in test
remove unused steps in feature tests
kept header in center, put the rest to the left
starting on restyling the emails
update text on en.yml WIP updating confirmation email
wip - styling the emails
added cors gem setup font and bootstrap in public folder WIP - styling the confirmation email
WIP - still styling the f.. emails
started on mjml review order mail
missing logo
uncommented code for sending email to movebybike
@magnus-thor what's the status on this one? |
…eview_email * 'develop' of github.com:CraftAcademy/gigafood: moved footer creation, needs to be setup before main content otherwise we have a empty first page added the gigafood logo to public folder changed pdf size to A4
@diraulo Waiting for a review of the email from Andreas |
added futura font to mjml emails
magnus-thor
force-pushed
the
new_review_email
branch
from
May 11, 2018 08:08
47c8e52
to
4234064
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/155034068
Review Order Email
Confirm Order Email