Header 컴포넌트 추가 #52
Merged
Header 컴포넌트 추가 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Likilee
reviewed
Apr 22, 2022
| pathname: string | ||
| } | ||
|
|
||
| const Hero: React.FC<HeroProps> = ({ image, title, description, onViewportEnter, onViewportLeave, pathname }) => { |
There was a problem hiding this comment.
컴포넌트 정의 컨벤션을 function 스타일로 한다고 하셨지 않나용??
Likilee
reviewed
Apr 22, 2022
0397364
to
efb369c
Compare
efb369c
to
3ea2837
Compare
Yenowme
approved these changes
Apr 24, 2022
| } | ||
|
|
||
| const title = 'JaeSeoKim' | ||
| const description = '🎢 To become a better developer...!' |
There was a problem hiding this comment.
이부분 어떻게 유저정보에서 받아오도록 할건지 궁금해요!
There was a problem hiding this comment.
저두 이 부분 궁금합니당!! config.json 파일에서 직접가져올 건지 혹은 context API 같은 걸 사용할 건지?? 궁금해요!!
| fontSize: '24px', | ||
| <LayoutGroup> | ||
| <Styled.rootContainer | ||
| initial={[isShowHero ? 'hero' : 'header']} |
There was a problem hiding this comment.
이 부분의 props들에 대한 설명 월요일에 부탁드립니다! 궁금해유
혹은 어떤 라이브러리 문서 참고하면 되는지 알려주셔도 좋을 것 같습니다
nyeoni
approved these changes
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Header 컴포넌트 제작