Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scrolling issue #169

Merged
merged 2 commits into from
Apr 11, 2021
Merged

fix: scrolling issue #169

merged 2 commits into from
Apr 11, 2021

Conversation

DanielHabenicht
Copy link
Collaborator

@DanielHabenicht DanielHabenicht commented Apr 9, 2021

no jumping of scroll bars anymore

workaround for: rjsf-team/react-jsonschema-form#1708

no jumping of scroll bars anymore
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2021

This PR is available as a preview here.

Copy link
Collaborator

@ChristophWersal ChristophWersal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version seems broken: question texts cannot be edited.
(Empty questionnaire => add question => change question text => nothing happens)

But: removing the current workaround with the callerIndex fixes everything for me. I cannot reproduce the original issue for the workaround. Could you post a detailed description of when the original issue (wrong onChange method is called) appears?

If it is still there: according to the linked issue in the library, this happens if the editor does not have a key => might it work to assign the current question id as key so that the editor onChange function works properly?

@ChristophWersal
Copy link
Collaborator

I found the fix in a later commit. Still: could you remind me when exactly the issue appears without the workaround?

@DanielHabenicht DanielHabenicht merged commit da2fdbe into master Apr 11, 2021
@DanielHabenicht
Copy link
Collaborator Author

DanielHabenicht commented Apr 11, 2021

@ChristophWersal The issue manifested itself if you load the app.

  1. Navigate to the Questionnaire Menu (top left)
  2. Select "Example CovApp"
  3. Select the first question
  4. Select the second question

==> The second question should now be duplicated in the first question

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants