Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/finish-db-models #7

Merged
merged 15 commits into from
Nov 7, 2020
Merged

feature/finish-db-models #7

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
08b0b56
Finish the base model definitions
Oct 30, 2020
62e16b2
Add tests for checking primary keys and indexes
Oct 30, 2020
7dc54f3
Add model indexes
Oct 30, 2020
06a7749
Rename ignore classes global
Oct 30, 2020
268e2a8
Fix MatterStatus primary keys and indexes
Nov 6, 2020
f481d91
Attempt to build on all platforms
Nov 6, 2020
5e0cb68
Fix tests
Nov 6, 2020
531d3f4
Install graphviz depending on platform
Nov 6, 2020
70099a7
Remove "yes" command to install commands
Nov 6, 2020
63e979b
Try without libgraphviz-dev on mac and windows
Nov 6, 2020
e0d01e4
Replace pygraphviz dep with pydot
Nov 6, 2020
9d0633a
Drop libgraphviz-dev from dep install
Nov 6, 2020
0144d77
Clean up the rest of the workflow files after build changes
Nov 6, 2020
b09e3fc
Update CRON timing to 10:24:00
Nov 6, 2020
54d5473
Move graphviz to actual requirements instead of test deps
Nov 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Replace pygraphviz dep with pydot
  • Loading branch information
JacksonMaxfield committed Nov 6, 2020
commit e0d01e42fe4b6dee6c098bb71251a6bbbd0866ab
2 changes: 1 addition & 1 deletion cdp_backend/tests/database/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def test_cdp_database_model_has_no_cyclic_dependencies(tmpdir):
_construct_dot_file(tmp_save_dot_path)

# Read dot as networkx digraph
G = nx.DiGraph(nx.drawing.nx_agraph.read_dot(tmp_save_dot_path))
G = nx.DiGraph(nx.drawing.nx_pydot.read_dot(tmp_save_dot_path))

# Get cycles
cycles = list(nx.simple_cycles(G))
Expand Down
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
"codecov>=2.1.4",
"flake8>=3.8.3",
"flake8-debugger>=3.2.1",
"graphviz>=0.14", # graphviz and pygraphviz are different
"graphviz>=0.14", # graphviz and pygraphviz are different, this is used for UML gen
"networkx>=2.5",
"pygraphviz>=1.6", # graphviz and pygraphviz are different
"pydot>=1.4", # graphviz and pydot are different, this one is used only for testing
"pytest>=5.4.3",
"pytest-cov>=2.9.0",
"pytest-raises>=0.11",
Expand Down