Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/uml-diagram #22

Merged
merged 1 commit into from
Nov 28, 2020
Merged

bugfix/uml-diagram #22

merged 1 commit into from
Nov 28, 2020

Conversation

evamaxfield
Copy link
Member

Pull request recommendations:

  • Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
  • Link to any relevant issue in the PR description. Ex: Resolves [Add builds for all platforms #12], adds tiff file format support

Resolves #19

  • Provide context of changes.

The UML diagram generation was broken due to it using collection_name for the bases of referenced models instead of the object name. i.e. body instead of Body.

  • Provide relevant tests for your feature or bug fix.
  • Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

@evamaxfield evamaxfield added bug Something isn't working documentation Improvements or additions to documentation labels Nov 28, 2020
@evamaxfield evamaxfield self-assigned this Nov 28, 2020
@codecov
Copy link

codecov bot commented Nov 28, 2020

Codecov Report

Merging #22 (1d757f9) into main (5fc7dfb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files          17       17           
  Lines         458      458           
=======================================
  Hits          452      452           
  Misses          6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fc7dfb...1d757f9. Read the comment docs.

@evamaxfield evamaxfield merged commit 7cfdb2d into main Nov 28, 2020
@evamaxfield evamaxfield deleted the bugfix/uml-diagram branch November 28, 2020 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix broken UML diagram
1 participant