feature/finish-db-models #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tohuynh
approved these changes
Nov 5, 2020
Codecov Report
@@ Coverage Diff @@
## main #7 +/- ##
==========================================
+ Coverage 93.91% 98.75% +4.84%
==========================================
Files 14 14
Lines 230 403 +173
==========================================
+ Hits 216 398 +182
+ Misses 14 5 -9
Continue to review full report at Codecov.
|
isaacna
approved these changes
Nov 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request recommendations:
Resolves #2
Resolves #12
Fully wraps up the Firestore database models (for now ^ tm). I expect as we develop out the cookiecutter, pipelines, and such we will find places we need to up change these models but for now I think they are decent.
Link to the original schema: here
Unfortunately our DB diagram doesn't look as great as it once did. A flaw of generate UML diagrams I suppose:
This also adds the
_INDEXESfor all models that use them and the PR for implementation changes on thecdp-deploysite can be seen hereThere are actually quite a few changes in this one. Please compare the schema doc and the code heavily. I expanded some things and reduced others where possible.
Added yet more tests for the model validation. Specifically about index and primary key checking.
Thanks for contributing!