Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump wasmvm #642

Merged
merged 2 commits into from
Apr 18, 2023
Merged

chore: bump wasmvm #642

merged 2 commits into from
Apr 18, 2023

Conversation

the-frey
Copy link
Collaborator

@the-frey the-frey commented Apr 18, 2023

Updating wasmvm to the latest version. Child's stuff.

Copy link
Contributor

@Reecepbcups Reecepbcups left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we do not need to do a go replace since we already use the wasmvm

@the-frey
Copy link
Collaborator Author

Good spot.

Copy link
Member

@dimiandre dimiandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Reecepbcups Reecepbcups merged commit e57bc00 into main Apr 18, 2023
@@ -34,7 +34,7 @@ require (
github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4 // indirect
github.com/99designs/keyring v1.2.1 // indirect
github.com/ChainSafe/go-schnorrkel v0.0.0-20200405005733-88cbf1b4c40d // indirect
github.com/CosmWasm/wasmvm v1.2.1 // indirect
github.com/CosmWasm/wasmvm v1.2.3 // indirect
Copy link
Collaborator

@webmaster128 webmaster128 Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this safe to never revert back? I mean all your direct dependencies only ask for 1.2.1 (github.com/CosmWasm/wasmd v0.31.0) and Go uses the lowest possible version of a dependency. But I'm not an expert wrt. Go build systems and indirect is a mystery to me.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of doubt, always check go.sum - this is what is being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants