Experiment with changing compile costs #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The linter is complaining about a piece of sed wrangling. Can we turn it off for bash scripts? We really don't care. |
|
cc @faddat can we turn off the linter for bash scripts? It's not actually correct in this case for the complex replacement syntax we have. If you change to its suggestion, the substitutions no longer work. |
|
@dimiandre / @faddat this is R4R I think now |
faddat
previously approved these changes
Sep 11, 2022
faddat
approved these changes
Sep 12, 2022
dimiandre
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for local testing. Do not merge.This is a proposed reduction in compilation cost.