Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CodeInfo rpc query #1943

Merged
merged 5 commits into from
Sep 11, 2024
Merged

Add CodeInfo rpc query #1943

merged 5 commits into from
Sep 11, 2024
+915 −142

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Aug 1, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Aug 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 46.42857% with 15 lines in your changes missing coverage. Please review.

Project coverage is 48.66%. Comparing base (2345840) to head (f740a14).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
x/wasm/keeper/querier.go 52.00% 6 Missing and 6 partials ⚠️
x/wasm/client/cli/query.go 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1943      +/-   ##
==========================================
+ Coverage   48.63%   48.66%   +0.02%     
==========================================
  Files          65       65              
  Lines       10019    10036      +17     
==========================================
+ Hits         4873     4884      +11     
- Misses       4716     4718       +2     
- Partials      430      434       +4
Files with missing lines Coverage Δ
x/wasm/client/cli/query.go 0.00% <0.00%> (ø)
x/wasm/keeper/querier.go 77.40% <52.00%> (-1.32%) ⬇️

webmaster128
webmaster128 reviewed Aug 1, 2024
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

cc @srdtrk

proto/cosmwasm/wasm/v1/query.proto Outdated Show resolved Hide resolved
x/wasm/client/cli/query.go Show resolved Hide resolved
chipshort
chipshort reviewed Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

proto/cosmwasm/wasm/v1/query.proto Outdated Show resolved Hide resolved
chipshort
chipshort approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pinosu pinosu merged commit 2e54595 into main Sep 11, 2024
16 of 17 checks passed
@pinosu pinosu deleted the add_codeinfo_query branch September 11, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipshort chipshort chipshort approved these changes

@webmaster128 webmaster128 Awaiting requested review from webmaster128

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pinosu @webmaster128 @chipshort