Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low memory inference fix #536

Merged
2 commits merged into from Sep 30, 2020
Merged

Low memory inference fix #536

2 commits merged into from Sep 30, 2020

Conversation

ghost
Copy link

@ghost ghost commented Sep 29, 2020

Resolves two separate issues:

  1. Use spawned workers instead of forked workers to resolve CUDA_NOT_INITIALIZED_ERROR (closes Cuda Error with low_mem #36)
  2. Passes seed to low_mem inference correctly, and in a way that does not require tensorflow to be pickled (closes NameError: name 'self' is not defined message appears when running in --low mem option #491, can't pickle tensorflow #529, Low memory inference fix #536)

Requesting @mineLdiver to download the 491_fix_lowmem_seed branch of my fork and test these changes to make sure they work.

@ghost ghost requested a review from CorentinJ September 30, 2020 07:08
@ghost
Copy link
Author

ghost commented Sep 30, 2020

This change has been tested by myself and @mineLdiver (#535 (comment)).

@ghost ghost merged commit ded7b37 into CorentinJ:master Sep 30, 2020
@ghost
Copy link
Author

ghost commented Sep 30, 2020

Thanks @CorentinJ . We can delete the low_mem_fix branch since it is now in master.

elliotthwang added a commit to elliotthwang/Real-Time-Voice-Cloning that referenced this pull request Oct 2, 2020
@ghost ghost deleted the 491_fix_lowmem_seed branch November 8, 2020 22:17
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant