Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: kill BLS12-378 and BW6-756 curves #534

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

yelhousni
Copy link
Collaborator

Description

This PR kills BLS12-378 and BW6-756 curves support. These are GT-strong 2-chains, i.e. no need to check if GT elements are of order r. This is useful for something like SNARKPack+composition, or anything that uses GT ops (e.g. SSLE). This was part of an external collaboration which never came into being.

Type of change

  • This change requires a documentation update

How has this been tested?

N/A

How has this been benchmarked?

N/A

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@yelhousni yelhousni added the cleanup Suggestion to clean up the code label Sep 5, 2024
@yelhousni yelhousni self-assigned this Sep 5, 2024
@yelhousni yelhousni merged commit e6b99e7 into master Sep 9, 2024
6 checks passed
@yelhousni yelhousni deleted the refactor/kill-some-curves branch September 9, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Suggestion to clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants