UUID as pk #175
Draft
UUID as pk #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hariso
reviewed
Jun 25, 2024
Comment on lines
+25
to
+27
| // Format returns: | ||
| // * string format of Time when connectorn is not builtin | ||
| // * time type in UTC when connector is builtin |
There was a problem hiding this comment.
Comment needs to be updated.
hariso
reviewed
Jun 25, 2024
| // * string format of Time when connectorn is not builtin | ||
| // * time type in UTC when connector is builtin | ||
| func (UUIDFormatter) Format(v any) (string, error) { | ||
| b, ok := v.([16]byte) |
There was a problem hiding this comment.
So a UUID can come in either as a byte slice (with type set to pgtype.UUIDOID) or as a string (what's the type in that case?)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and what type of change it is (new feature, bug fix, refactoring, documentation).
Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Quick checks: