Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.4.11 - strange navigation menu behavior + dark space on reloads #2126

Closed
toxpal opened this issue Jun 11, 2019 · 3 comments
Closed

2.4.11 - strange navigation menu behavior + dark space on reloads #2126

toxpal opened this issue Jun 11, 2019 · 3 comments

Comments

@toxpal
Copy link

toxpal commented Jun 11, 2019 •
edited
Loading

Upgraded to 2.4.11 several minutes ago and noticed 2 strange things (never happened with previous releases):

  1. Navigation menu is not smooth anymore. Now, if I have one of menus opened (so other menus are closed) and click on closed menu to open it, currently opened menu just collapses instantly, which looks bad. It was collapsing slowly and smoothly in previous builds. Don't know how to explain it better, but if you play with live demo, you will notice how bad and unnatural collapsing looks now.

  2. All the pages that don't take 100% (or more) of screen's height now display dark space at the bottom during reloads. It only happens for a second or so, but it's really annoying. To see what I mean go to any small page (like https://adminlte.io/themes/AdminLTE/pages/examples/pace.html) and use forced reload (usually CTRL + F5). When page reloads, you will notice it displays dark color (the same one used by menu) in almost whole page, which only disappears after page is fully loaded.
REJack added a commit that referenced this issue Jun 11, 2019
@REJack
fixed strange navigation menu behavior + dark space on reloads (#2126)
340bbba 
- changed height: 0px to height: auto for uk.treeview-menu to fix not smooth treeview closing
- fixed .content-wrapper calc, it returned -2% before
- changed order of js file generation
- rebuild dist files
@REJack
Copy link
Collaborator

REJack commented Jun 11, 2019

I've fixed both issues, you can test it on the offical demo page.

@REJack REJack closed this as completed Jun 11, 2019
@toxpal
Copy link
Author

toxpal commented Jun 11, 2019

Thank you, that was fast!

@REJack
Copy link
Collaborator

REJack commented Jun 11, 2019

No problem 😄

rkorzeniewski pushed a commit to inteos/AdminLTE that referenced this issue Oct 30, 2019
@REJack @rkorzeniewski
fixed strange navigation menu behavior + dark space on reloads (Color…
36e8dd5 
…libHQ#2126)

- changed height: 0px to height: auto for uk.treeview-menu to fix not smooth treeview closing
- fixed .content-wrapper calc, it returned -2% before
- changed order of js file generation
- rebuild dist files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@REJack @toxpal