-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added files to be ignored by .gitignore #8
Conversation
Interesting, how does ignoring two modules files fix the problem? Is there a known reason or just straight magic? Also i'm declining the other pull request to update gradle because it's also on this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All ok, I don't fully understand why but seems reasonable
@@ -38,6 +38,8 @@ captures/ | |||
.idea/tasks.xml | |||
.idea/gradle.xml | |||
.idea/assetWizardSettings.xml | |||
.idea/modules.xml | |||
.idea/navEditor.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seen it also in https://gist.github.com/iainconnor/8605514
Might be a good thing to do then
@CremaLuca All I know is that Marco used a gitignore suggested by GitHub when he created the repository, while the gitignore we had in our group project was generated by Android Studio. I'm guessing the second way is better because the way Android Studio works changes with updates, and GitHub might not be always up to date with Android Studio changes. |
Yup, we can either let android studio create it's own, or use the one in the link @CremaLuca posted. |
Also if this problem is here, then it's also in killer-app and network-dictionary |
I think we should use the one generated by Android Studio since we don't know if the one linked above will always be up to date. |
Ok, now the pull request can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, seems fine to me too 👍 ready to be merged
Merge it then |
Was waiting for @CremaLuca to see, seems there's no reason to wait so I'll merge myself |
updated .gitignore (Cogno-Marco#8)
I was having problems with loading project settings on my machine, adding these files to .gitignore (which were ignored in our group's projects) seems to have fixed the issue.