Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

responsive_utils.dart not included as an export in responsive_framework.dart #181

Open
mstainer14 opened this issue Jun 21, 2024 · 5 comments

Comments

@mstainer14
Copy link
Contributor

When developing for web, the breakpointsLandscape property of ResponsiveBreakpoints.builder does not work as intended because the default value of _landscapePlatforms in responsive_breakpoints.dart is set to the following:

  static const List<ResponsiveTargetPlatform> _landscapePlatforms = [
    ResponsiveTargetPlatform.iOS,
    ResponsiveTargetPlatform.android,
    ResponsiveTargetPlatform.fuchsia,
  ];

In order to overcome this we need to set the landscapePlatforms property of ResponsiveBreakpoints.builder. However, because responsive_utils.dart is not included as an export in the barrel file, we cannot access the ResponsiveTargetPlatform class directly but have to manually import the file import 'package:responsive_framework/src/utils/responsive_utils.dart'; which gives us the following error.

Import of a library in the 'lib/src' directory of another package.
Try importing a public library that exports this library, or removing the import.dart[implementation_imports](https://dart.dev/lints/implementation_imports)

library package:responsive_framework/src/utils/responsive_utils.dart

Is it possible to add the responsive_utils.dart to the export file or move to a new location that is accessible through the import?

Many thanks

@mstainer14
Copy link
Contributor Author

@rayliverified

@rayliverified
Copy link
Contributor

rayliverified commented Jun 21, 2024 via email

@mstainer14
Copy link
Contributor Author

#182

@Juliotati
Copy link

Juliotati commented Jun 22, 2024

@rayliverified Any prevision on when this gets published?
I noticed there is no version bump on the PR 👀 (and it’s not linked to this issue either)
Screenshot 2024-06-23 at 00 51 21

@rayliverified
Copy link
Contributor

Not yet. I need to bundle some other changes for publishing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants