Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables PR #2926

Merged
merged 8 commits into from
Aug 23, 2023
Merged

Tables PR #2926

merged 8 commits into from
Aug 23, 2023

Conversation

AngelAvilaGit
Copy link
Contributor

Description

Type of Change

  • Adding a new entry
  • Editing an existing entry (fixing a typo, bug, issues, etc)
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

@CLAassistant
Copy link

CLAassistant commented Aug 2, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@lucwhite lucwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Angel, left a few suggestions, let me know if you have any questions!

content/lua/concepts/tables/tables.md Outdated Show resolved Hide resolved
content/lua/concepts/tables/tables.md Outdated Show resolved Hide resolved
content/lua/concepts/tables/tables.md Outdated Show resolved Hide resolved
content/lua/concepts/tables/tables.md Outdated Show resolved Hide resolved
content/lua/concepts/tables/tables.md Outdated Show resolved Hide resolved
content/lua/concepts/tables/tables.md Outdated Show resolved Hide resolved
@SSwiniarski
Copy link
Contributor

@AngelAvilaGit please remember to sign the Contributor License Agreement

@AngelAvilaGit
Copy link
Contributor Author

@AngelAvilaGit please remember to sign the Contributor License Agreement

Signed!

Copy link
Collaborator

@lucwhite lucwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Ready for 2nd review

@caupolicandiaz
Copy link
Contributor

@AngelAvilaGit @lucwhite From what I've read, Lua doesn't really have arrays, only tables. I think the arrays entry should be renamed tables, and a terms folder can be added in the future that contain the methods documented here.

@AngelAvilaGit
Copy link
Contributor Author

@AngelAvilaGit @lucwhite From what I've read, Lua doesn't really have arrays, only tables. I think the arrays entry should be renamed tables, and a terms folder can be added in the future that contains the methods documented here.

In Lua, we generally call Tables Arrays as table itself is a global term. When I mention arrays, I'm referring to numerically indexed arrays as opposed to associative arrays which follow a Key:Value format instead of a number:Value format.

Should I rename/revise anything on my end?

@lucwhite
Copy link
Collaborator

lucwhite commented Aug 10, 2023

In Lua, we generally call Tables Arrays as table itself is a global term. When I mention arrays, I'm referring to numerically indexed arrays as opposed to associative arrays which follow a Key:Value format instead of a number:Value format.

Should I rename/revise anything on my end?

Lua docs on Arrays for context & the Arrays PR

@yangc95 yangc95 added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Aug 16, 2023
@yangc95 yangc95 self-assigned this Aug 16, 2023
- Added to future term issues
Copy link
Contributor

@yangc95 yangc95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some direct changes @AngelAvilaGit LGTM!

Also, I used your exact wordings in creating the follow-up issues for the functions that will populate here as table function terms.

@yangc95 yangc95 added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Aug 23, 2023
@yangc95 yangc95 merged commit 6bf546d into Codecademy:main Aug 23, 2023
5 checks passed
@github-actions
Copy link

👋 @AngelAvilaGit
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/lua/tables

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants