-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tables PR #2926
Tables PR #2926
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Angel, left a few suggestions, let me know if you have any questions!
@AngelAvilaGit please remember to sign the Contributor License Agreement |
Signed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Ready for 2nd review
@AngelAvilaGit @lucwhite From what I've read, Lua doesn't really have arrays, only tables. I think the arrays entry should be renamed tables, and a terms folder can be added in the future that contain the methods documented here. |
In Lua, we generally call Tables Arrays as Should I rename/revise anything on my end? |
|
- Added to future term issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some direct changes @AngelAvilaGit LGTM!
Also, I used your exact wordings in creating the follow-up issues for the functions that will populate here as table function terms.
👋 @AngelAvilaGit 🎉 Your contribution(s) can be seen here: https://www.codecademy.com/resources/docs/lua/tables Please note it may take a little while for changes to become visible. |
Description
Type of Change
Checklist
main
branch.