Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2511 add codebytes for javascript promise race and reject #2778

Conversation

carlos-ds
Copy link
Contributor

Description

Added Codebyte examples for Promise.reject and Promise.race

Closes #2511

Type of Change

Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

Copy link
Contributor

@SSwiniarski SSwiniarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlos-ds This looks good as-is. Passing it on to a second review.

@SSwiniarski SSwiniarski self-assigned this Jul 18, 2023
@KTom101 KTom101 added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Aug 15, 2023
@KTom101 KTom101 self-assigned this Aug 15, 2023
Copy link
Contributor

@KTom101 KTom101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlos-ds I added some changes to the original content. Looks good, otherwise.

@KTom101 KTom101 merged commit b8e565c into Codecademy:main Aug 17, 2023
5 checks passed
@github-actions
Copy link

👋 @carlos-ds
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/javascript/promise/race
https://www.codecademy.com/resources/docs/javascript/promise/reject

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript JavaScript entries status: review 1️⃣ completed status: under review Issue or PR is currently being reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Edit] JavaScript Add Codebytes
3 participants