Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvments #278

Closed
wants to merge 15 commits into from
Closed

Some improvments #278

wants to merge 15 commits into from

Conversation

hazyfossa
Copy link

Hey, found this great project, thought i can do something useful. Please let me know if you guys accept contributions, i can probably do much more

@hazyfossa
Copy link
Author

Also btw, is there a reason this depends on pyromod 1.5? Its not used anywhere it seems..

@hazyfossa
Copy link
Author

Oh, it seems pyromod is patching pyrogram on-the-fly somewhere, so vscode is unable to pick it as used. Leaving it be :)

@hazyfossa hazyfossa changed the title Some minor improvments Some improvments Nov 10, 2023
@hazyfossa
Copy link
Author

@rahulps1000 if you aren't busy, can you provide some feedback, i'm still not sure if the work is useful for the project.

@hazyfossa
Copy link
Author

I'm planning to rewrite the whole way errors are handled, because right now thats inconsistent between plugins and most of them are silenced, so debugging is a pain. You are already using logging module in the bot.py, so it makes sense to expand on it.

@hazyfossa
Copy link
Author

Also mongodb seems like overkill and is underused as the same time. Its a huge thing requiring it's own hosting, but used only for message broadcasting. I'll probably add a database-backend based on montydb instead to host the database in-process and leave mongo as optional.

@hazyfossa
Copy link
Author

Your feedback will allow me to proceed with writing these changes, as they require more effort

@hazyfossa
Copy link
Author

Sorry y'all, sadly don't have the time to finish this

@hazyfossa hazyfossa closed this Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants