Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add people's last words (easy PR) #1

Open
CodeWritingCow opened this issue Oct 30, 2017 · 6 comments
Open

Add people's last words (easy PR) #1

CodeWritingCow opened this issue Oct 30, 2017 · 6 comments
Labels
good first issue hacktoberfest help wanted

Comments

@CodeWritingCow
Copy link
Owner

CodeWritingCow commented Oct 30, 2017 •
edited

Add people's last words, whether famous or obscure. Just follow the specs in README.md!
@NeroAzure
Copy link
Contributor

NeroAzure commented Oct 30, 2017 •
edited

how about lastnames that are separated by a hyphen? like Bismarck-Schönhausen? wouldn't it screw with your file naming convention?

@spanishharlem
Copy link
Contributor

How about naming files with people such as Pope John Paul II?

@TwoRice
Copy link
Contributor

TwoRice commented Oct 30, 2017

How should the naming work for people with stage names, nicknames or shortened names that differ from their birth certificate names?

@jonmstewart jonmstewart mentioned this issue Oct 31, 2017
Merged
mailtobash referenced this issue in mailtobash/their-last-words Oct 31, 2017
@mailtobash
Issue #1 Add name
1cd294d
@mailtobash mailtobash mentioned this issue Oct 31, 2017
Merged
mjzone referenced this issue in mjzone/their-last-words Oct 31, 2017
@mjzone
Added Arthur C. Clarke mailtobash#1
8cf3522
nilupull pushed a commit to nilupull/their-last-words that referenced this issue Oct 31, 2017
@nilupull-99x
Added Bob Marley CodeWritingCow#1
9821fab
@adellahlou adellahlou mentioned this issue Oct 31, 2017
Merged
@CodeWritingCow
Copy link
Owner Author

@NeroAzure that's a good question. I'm leaning toward using the hyphenated last name, ex. bismarck-schönhausen-josef.json. What do you think?

@CodeWritingCow
Copy link
Owner Author

@Nalapl3 and @TwoRice, let's go with the names that they were best known by. A couple example:

  • pope-john-paul-ii.json.
  • Same with stage names. Everyone knows monroe-marilyn.json. Only a few would recognize mortenson-norma-jeane.json.
    I'll update README.md accordingly. These questions never occurred to me until you asked. Thanks guys!

CodeWritingCow added a commit that referenced this issue Oct 31, 2017
@CodeWritingCow
Merge pull request #22 from mailtobash/doyle
db7dc65 
Issue #1 Add Arthur conan doyle name
@knighthedspi
Copy link

I create PR28 for Alexander the Great
Please review

CodeWritingCow added a commit that referenced this issue Nov 2, 2017
@CodeWritingCow
Add Adolf Eichmann's last words
0414372 
#1
CodeWritingCow added a commit that referenced this issue Nov 2, 2017
@CodeWritingCow
Add last words of killers before their executions
1245d08 
#1
CodeWritingCow added a commit that referenced this issue Nov 7, 2017
@CodeWritingCow
Add quotes - Issue #1
2a46067 
Also add note to Napoloean file.
CodeWritingCow added a commit that referenced this issue Nov 8, 2017
@CodeWritingCow
Add Goethe last words
2e50145 
Issue #1
CodeWritingCow added a commit that referenced this issue Dec 27, 2017
@CodeWritingCow
Add Eric Garner
f71303d 
Issue #1
CodeWritingCow added a commit that referenced this issue Dec 31, 2017
@CodeWritingCow
Add Thomas Edison and Steve Jobs
68b99ee 
Issue #1
CodeWritingCow added a commit that referenced this issue Jan 2, 2018
@CodeWritingCow
Add David Cassidy
6c8a807 
Issue #1
CodeWritingCow added a commit that referenced this issue Jan 2, 2018
@CodeWritingCow
Add Crowfoot
02de56e 
Issue #1
CodeWritingCow added a commit that referenced this issue Mar 8, 2018
@CodeWritingCow
Add Inukai Tsuyoshi
823f6b7 
Issue #1
CodeWritingCow added a commit that referenced this issue May 6, 2018
@CodeWritingCow
Add Robert Earl Butts Jr.
7282332 
Issue #1
CodeWritingCow added a commit that referenced this issue May 19, 2018
@CodeWritingCow
Add people's last words
5ccda91 
Add Christine Chubbuck, Empress Josephine and Dominick Napolitano. Edit
Christopher Columbus. Issue #1
@simonaltrogge simonaltrogge mentioned this issue Oct 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue hacktoberfest help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@knighthedspi @NeroAzure @CodeWritingCow @TwoRice @spanishharlem