fix: When custom resources are created on api gateway and mapped with… #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the NestJS proxy, it was not working as expected. The fix is made to address that issue
|
🎉 This PR is included in version 4.3.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
brett-vendia
pushed a commit
that referenced
this pull request
Aug 31, 2021
OneDev0411
added a commit
to OneDev0411/serverless-express
that referenced
this pull request
Mar 16, 2023
## [4.3.11](CodeGenieApp/serverless-express@v4.3.10...v4.3.11) (2021-08-31) ### Bug Fixes * revert [#441](CodeGenieApp/serverless-express#441) ([#455](CodeGenieApp/serverless-express#455)) ([87aa26f](CodeGenieApp/serverless-express@87aa26f)), closes [#454](CodeGenieApp/serverless-express#454)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the NestJS proxy, it was not working as expected. The fix is made to address that issue
Issue #, if available: if the API gateway has custom resource/route setup, for example if my controllers path is something like employee/services/service1, employee/services/service2 etc, if I don't have any custom path/resources setup in the API gateway and directly have root/{proxy+} it works as expected, if i have a resource like /employee and child to that if there
is a resource like {proxy+} it is not working as expected and errors out with 404. This change is required to address that specific issue.
Description of changes: Always use the path that is passed on in the event argument.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.