Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebuild Cached Files After Rename, Git Status Label #1866

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Rebuild Cached Files After Rename, Git Status Label #1866

merged 1 commit into from
Aug 31, 2024

Conversation

thecoolwinter
Copy link
Collaborator

Description

  • Updates the rename method to get a new, cached, file instead of creating one unrelated to the rest of the tree.
  • Removes the temporary tab when closing a tab if the tab was the temporary tab.
  • Updates the git status label to use a dynamic color, so it appears white when the cell is selected.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Renaming, now selects new file after rename. File changes are saved between names. Editor can close the tab and keeps the ability to select new tabs.

Screen.Recording.2024-08-25.at.11.52.41.PM.mov

Git status label

Screenshot 2024-08-25 at 11 32 59 PM

@thecoolwinter thecoolwinter added the bug Something isn't working label Aug 26, 2024
tom-ludwig
tom-ludwig requested changes Aug 26, 2024
View reviewed changes
Copy link
Member

@tom-ludwig tom-ludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I don’t think it’s necessary to disable SwiftLint in CEWorkspaceFileManager

CodeEdit/Features/CEWorkspace/Models/CEWorkspaceFileManager.swift Show resolved Hide resolved
@thecoolwinter
Copy link
Collaborator Author

Whoops, @activcoding I accidentally dismissed your review

@tom-ludwig
Copy link
Member

No Problem 😉

@thecoolwinter thecoolwinter merged commit 4bc7548 into CodeEditApp:main Aug 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austincondiff austincondiff austincondiff approved these changes

@tom-ludwig tom-ludwig tom-ludwig approved these changes

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 Editor Crashes After renaming a file
3 participants
@thecoolwinter @tom-ludwig @austincondiff