Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Terminal State Loss #1843

Merged
merged 5 commits into from
Aug 25, 2024

Conversation

thecoolwinter
Copy link
Collaborator

@thecoolwinter thecoolwinter commented Aug 8, 2024

Description

  • Fixes terminals losing their state when focus is changed away from them.
  • Pins a version of SwiftTerm with changes including:
  • Fixes the trash button in the terminals.
  • Removes a little bit of extra padding from the top of the terminal view.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2024-08-19.at.3.58.44.PM.mov

@austincondiff
Copy link
Collaborator

Did the sidebar expand like that before when changing selection?

@thecoolwinter thecoolwinter added the enhancement New feature or request label Aug 23, 2024
Copy link
Member

@tom-ludwig tom-ludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one small tweak needed

@tom-ludwig tom-ludwig enabled auto-merge (squash) August 25, 2024 14:55
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Terminal is really shaping up

@tom-ludwig tom-ludwig merged commit 0bf177f into CodeEditApp:main Aug 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request terminal
Projects
None yet
4 participants