Full Quick Look support #1807
Closed
Full Quick Look support #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… '.gitignore', '.editorconfig')
…s with a ".", every component will be checked to get a valid type.
…s with a ".", every component will be checked to get a valid type.
#Conflicts: # CodeEdit/Features/CEWorkspace/Models/CEWorkspaceFile.swift
added 4 commits
July 10, 2024 23:24
#Conflicts: # CodeEdit/Features/Editor/TabBar/Tabs/Tab/EditorTabView.swift
…pened with Quick Look, clicking this option will opened the default CodeEdit editor.
thecoolwinter
requested changes
Jul 11, 2024
added 2 commits
July 11, 2024 12:28
…s by missing files.
|
There are merge conflicts with main |
|
I don't get it, in my pull request I didn't modified that file and it's 396 lines long, waiting for issue to be resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request brings full Quick Look support. This means that now, any type of file compatible with Quick Look can be viewed within CodeEdit (such as videos).
Related Issues
Checklist
Screenshots
Menu
Video
Screen.Recording.2024-07-10.at.23.04.25.mov
Update 1
Opened in code editor (left). Opened with Quick Look (right).
Update 2
Open As -> Source Code menu item is now enabled. When having a file opened with Quick Look, clicking this option will opened the file in the default CodeEdit editor.
Screen.Recording.2024-07-10.at.23.50.55.mov