Skip to content

Commit

Permalink
Kernel/Devices: Remove SerialDevice::initialize method
Browse files Browse the repository at this point in the history
We can just do the initialization sequence in the constructor.
  • Loading branch information
supercomputer7 authored and ADKaster committed May 14, 2024
1 parent b4c2181 commit cb558f4
Showing 1 changed file with 5 additions and 10 deletions.
15 changes: 5 additions & 10 deletions Kernel/Devices/SerialDevice.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ SerialDevice::SerialDevice(NonnullOwnPtr<IOWindow> registers_io_window, unsigned
: CharacterDevice(4, minor)
, m_registers_io_window(move(registers_io_window))
{
initialize();
set_interrupts(false);
set_baud(Baud38400);
set_line_control(None, One, EightBits);
set_fifo_control(EnableFIFO | ClearReceiveFIFO | ClearTransmitFIFO | TriggerLevel4);
set_modem_control(RequestToSend | DataTerminalReady);
}

SerialDevice::~SerialDevice() = default;
Expand Down Expand Up @@ -76,15 +80,6 @@ void SerialDevice::put_char(char ch)
m_last_put_char_was_carriage_return = (ch == '\r');
}

void SerialDevice::initialize()
{
set_interrupts(false);
set_baud(Baud38400);
set_line_control(None, One, EightBits);
set_fifo_control(EnableFIFO | ClearReceiveFIFO | ClearTransmitFIFO | TriggerLevel4);
set_modem_control(RequestToSend | DataTerminalReady);
}

void SerialDevice::set_interrupts(bool interrupt_enable)
{
m_interrupt_enable = interrupt_enable;
Expand Down

0 comments on commit cb558f4

Please sign in to comment.