Kernel+Userland: Remove shared buffers (shbufs)

All users of this mechanism have been switched to anonymous files and passing file descriptors with sendfd()/recvfd(). Shbufs got us where we are today, but it's time we say good-bye to them and welcome a much more idiomatic replacement. :^)
Cnidarias · Jan 17, 2021 · bf07190 · bf07190
1 parent 2cd1677
commit bf07190
Show file tree

Hide file tree

Showing 28 changed files with 2 additions and 1,022 deletions.
diff --git a/AK/Debug.h b/AK/Debug.h
@@ -46,12 +46,6 @@ constexpr bool debug_scheduler_runnable = true;
 constexpr bool debug_scheduler_runnable = false;
 #endif
 
-#ifdef SHARED_BUFFER_DEBUG
-constexpr bool debug_shared_buffer = true;
-#else
-constexpr bool debug_shared_buffer = false;
-#endif
-
 #ifdef THREAD_DEBUG
 constexpr bool debug_thread = true;
 #else

diff --git a/AK/Forward.h b/AK/Forward.h
@@ -38,7 +38,6 @@ class JsonArray;
 class JsonObject;
 class JsonValue;
 class LogStream;
-class SharedBuffer;
 class StackInfo;
 class String;
 class StringBuilder;
@@ -169,7 +168,6 @@ using AK::OutputStream;
 using AK::OwnPtr;
 using AK::ReadonlyBytes;
 using AK::RefPtr;
-using AK::SharedBuffer;
 using AK::SinglyLinkedList;
 using AK::Span;
 using AK::StackInfo;

diff --git a/AK/SharedBuffer.cpp b/AK/SharedBuffer.cpp
diff --git a/AK/SharedBuffer.h b/AK/SharedBuffer.h
diff --git a/Base/usr/share/man/man2/pledge.md b/Base/usr/share/man/man2/pledge.md
@@ -45,7 +45,6 @@ If the process later attempts to use any system functionality it has previously
 * `dpath`: Creating new device files
 * `chown`: Changing file owner/group
 * `fattr`: Changing file attributes/permissions
-* `shared_buffer`: Shared memory buffers (\*)
 * `chroot`: The [`chroot(2)`](chroot.md) syscall (\*)
 * `video`: May use [`ioctl(2)`](ioctl.md) and [`mmap(2)`](mmap.md) on framebuffer video devices
 * `settime`: Changing the system time and date

diff --git a/Base/usr/share/man/man2/shbuf_allow_pid.md b/Base/usr/share/man/man2/shbuf_allow_pid.md
diff --git a/Base/usr/share/man/man2/shbuf_create.md b/Base/usr/share/man/man2/shbuf_create.md
diff --git a/Kernel/API/Syscall.h b/Kernel/API/Syscall.h
@@ -121,10 +121,6 @@ namespace Kernel {
  S(accept) \
  S(listen) \
  S(connect) \
- S(shbuf_create) \
- S(shbuf_allow_pid) \
- S(shbuf_get) \
- S(shbuf_release) \
  S(link) \
  S(chown) \
  S(fchmod) \

diff --git a/Kernel/CMakeLists.txt b/Kernel/CMakeLists.txt
@@ -101,7 +101,6 @@ set(KERNEL_SOURCES
  RTC.cpp
  Random.cpp
  Scheduler.cpp
- SharedBuffer.cpp
  StdLib.cpp
  Syscall.cpp
  Syscalls/anon_create.cpp
@@ -157,7 +156,6 @@ set(KERNEL_SOURCES
  Syscalls/setkeymap.cpp
  Syscalls/setpgid.cpp
  Syscalls/setuid.cpp
- Syscalls/shbuf.cpp
  Syscalls/shutdown.cpp
  Syscalls/sigaction.cpp
  Syscalls/socket.cpp

diff --git a/Kernel/Forward.h b/Kernel/Forward.h
@@ -60,7 +60,6 @@ class RangeAllocator;
 class Region;
 class Scheduler;
 class SchedulerPerProcessorData;
-class SharedBuffer;
 class Socket;
 template<typename BaseType>
 class SpinLock;

diff --git a/Kernel/Process.cpp b/Kernel/Process.cpp
@@ -45,10 +45,10 @@
 #include <Kernel/PerformanceEventBuffer.h>
 #include <Kernel/Process.h>
 #include <Kernel/RTC.h>
-#include <Kernel/SharedBuffer.h>
 #include <Kernel/StdLib.h>
 #include <Kernel/TTY/TTY.h>
 #include <Kernel/Thread.h>
+#include <Kernel/VM/AnonymousVMObject.h>
 #include <Kernel/VM/PageDirectory.h>
 #include <Kernel/VM/PrivateInodeVMObject.h>
 #include <Kernel/VM/ProcessPagingScope.h>
@@ -644,7 +644,6 @@ void Process::finalize()
 
  m_dead = true;
 
- disown_all_shared_buffers();
  {
  // FIXME: PID/TID BUG
  if (auto parent_thread = Thread::from_tid(m_ppid.value())) {