Services: Use default constructors/destructors

https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules "The compiler is more likely to get the default semantics right and you cannot implement these functions better than the compiler."
Cnidarias · Mar 25, 2022 · 0b7baa7 · 0b7baa7
1 parent 5550905
commit 0b7baa7
Show file tree

Hide file tree

Showing 80 changed files with 50 additions and 202 deletions.
diff --git a/Userland/Services/AudioServer/ConnectionFromClient.cpp b/Userland/Services/AudioServer/ConnectionFromClient.cpp
@@ -29,10 +29,6 @@ ConnectionFromClient::ConnectionFromClient(NonnullOwnPtr<Core::Stream::LocalSock
  s_connections.set(client_id, *this);
 }
 
-ConnectionFromClient::~ConnectionFromClient()
-{
-}
-
 void ConnectionFromClient::die()
 {
  s_connections.remove(client_id());

diff --git a/Userland/Services/AudioServer/ConnectionFromClient.h b/Userland/Services/AudioServer/ConnectionFromClient.h
@@ -23,7 +23,7 @@ class Mixer;
 class ConnectionFromClient final : public IPC::ConnectionFromClient<AudioClientEndpoint, AudioServerEndpoint> {
  C_OBJECT(ConnectionFromClient)
 public:
- ~ConnectionFromClient() override;
+ ~ConnectionFromClient() override = default;
 
  void did_finish_playing_buffer(Badge<ClientAudioStream>, int buffer_id);
  void did_change_client_volume(Badge<ClientAudioStream>, double volume);

diff --git a/Userland/Services/AudioServer/Mixer.cpp b/Userland/Services/AudioServer/Mixer.cpp
@@ -44,10 +44,6 @@ Mixer::Mixer(NonnullRefPtr<Core::ConfigFile> config)
  m_sound_thread->start();
 }
 
-Mixer::~Mixer()
-{
-}
-
 NonnullRefPtr<ClientAudioStream> Mixer::create_queue(ConnectionFromClient& client)
 {
  auto queue = adopt_ref(*new ClientAudioStream(client));

diff --git a/Userland/Services/AudioServer/Mixer.h b/Userland/Services/AudioServer/Mixer.h
@@ -35,7 +35,7 @@ class ConnectionFromClient;
 class ClientAudioStream : public RefCounted<ClientAudioStream> {
 public:
  explicit ClientAudioStream(ConnectionFromClient&);
- ~ClientAudioStream() { }
+ ~ClientAudioStream() = default;
 
  bool is_full() const { return m_queue.size() >= 3; }
  void enqueue(NonnullRefPtr<Audio::Buffer>&&);
@@ -112,7 +112,7 @@ class ClientAudioStream : public RefCounted<ClientAudioStream> {
 class Mixer : public Core::Object {
  C_OBJECT(Mixer)
 public:
- virtual ~Mixer() override;
+ virtual ~Mixer() override = default;
 
  NonnullRefPtr<ClientAudioStream> create_queue(ConnectionFromClient&);
 

diff --git a/Userland/Services/ChessEngine/ChessEngine.h b/Userland/Services/ChessEngine/ChessEngine.h
@@ -12,14 +12,14 @@
 class ChessEngine : public Chess::UCI::Endpoint {
  C_OBJECT(ChessEngine)
 public:
- virtual ~ChessEngine() override { }
+ virtual ~ChessEngine() override = default;
 
  virtual void handle_uci() override;
  virtual void handle_position(const Chess::UCI::PositionCommand&) override;
  virtual void handle_go(const Chess::UCI::GoCommand&) override;
 
 private:
- ChessEngine() { }
+ ChessEngine() = default;
  ChessEngine(NonnullRefPtr<Core::IODevice> in, NonnullRefPtr<Core::IODevice> out)
  : Endpoint(in, out)
  {

diff --git a/Userland/Services/Clipboard/ConnectionFromClient.cpp b/Userland/Services/Clipboard/ConnectionFromClient.cpp
@@ -25,10 +25,6 @@ ConnectionFromClient::ConnectionFromClient(NonnullOwnPtr<Core::Stream::LocalSock
  s_connections.set(client_id, *this);
 }
 
-ConnectionFromClient::~ConnectionFromClient()
-{
-}
-
 void ConnectionFromClient::die()
 {
  s_connections.remove(client_id());

diff --git a/Userland/Services/Clipboard/ConnectionFromClient.h b/Userland/Services/Clipboard/ConnectionFromClient.h
@@ -18,7 +18,7 @@ class ConnectionFromClient final
  C_OBJECT(ConnectionFromClient);
 
 public:
- virtual ~ConnectionFromClient() override;
+ virtual ~ConnectionFromClient() override = default;
 
  virtual void die() override;
 

diff --git a/Userland/Services/Clipboard/Storage.cpp b/Userland/Services/Clipboard/Storage.cpp
@@ -14,14 +14,6 @@ Storage& Storage::the()
  return s_the;
 }
 
-Storage::Storage()
-{
-}
-
-Storage::~Storage()
-{
-}
-
 void Storage::set_data(Core::AnonymousBuffer data, const String& mime_type, const HashMap<String, String>& metadata)
 {
  m_buffer = move(data);

diff --git a/Userland/Services/Clipboard/Storage.h b/Userland/Services/Clipboard/Storage.h
@@ -16,7 +16,7 @@ namespace Clipboard {
 class Storage {
 public:
  static Storage& the();
- ~Storage();
+ ~Storage() = default;
 
  bool has_data() const { return m_buffer.is_valid(); }
 
@@ -44,7 +44,7 @@ class Storage {
  const Core::AnonymousBuffer& buffer() const { return m_buffer; }
 
 private:
- Storage();
+ Storage() = default;
 
  String m_mime_type;
  Core::AnonymousBuffer m_buffer;

diff --git a/Userland/Services/ConfigServer/ConnectionFromClient.cpp b/Userland/Services/ConfigServer/ConnectionFromClient.cpp
@@ -81,10 +81,6 @@ ConnectionFromClient::ConnectionFromClient(NonnullOwnPtr<Core::Stream::LocalSock
  s_connections.set(client_id, *this);
 }
 
-ConnectionFromClient::~ConnectionFromClient()
-{
-}
-
 void ConnectionFromClient::die()
 {
  s_connections.remove(client_id());

diff --git a/Userland/Services/ConfigServer/ConnectionFromClient.h b/Userland/Services/ConfigServer/ConnectionFromClient.h
@@ -16,7 +16,7 @@ namespace ConfigServer {
 class ConnectionFromClient final : public IPC::ConnectionFromClient<ConfigClientEndpoint, ConfigServerEndpoint> {
  C_OBJECT(ConnectionFromClient)
 public:
- ~ConnectionFromClient() override;
+ ~ConnectionFromClient() override = default;
 
  virtual void die() override;
 

diff --git a/Userland/Services/DHCPClient/DHCPv4Client.cpp b/Userland/Services/DHCPClient/DHCPv4Client.cpp
@@ -201,10 +201,6 @@ ErrorOr<DHCPv4Client::Interfaces> DHCPv4Client::get_discoverable_interfaces()
  };
 }
 
-DHCPv4Client::~DHCPv4Client()
-{
-}
-
 void DHCPv4Client::handle_offer(const DHCPv4Packet& packet, const ParsedDHCPv4Options& options)
 {
  dbgln("We were offered {} for {}", packet.yiaddr().to_string(), options.get<u32>(DHCPOption::IPAddressLeaseTime).value_or(0));

diff --git a/Userland/Services/DHCPClient/DHCPv4Client.h b/Userland/Services/DHCPClient/DHCPv4Client.h
@@ -40,7 +40,7 @@ class DHCPv4Client final : public Core::Object {
  C_OBJECT(DHCPv4Client)
 
 public:
- virtual ~DHCPv4Client() override;
+ virtual ~DHCPv4Client() override = default;
 
  void dhcp_discover(const InterfaceDescriptor& ifname);
  void dhcp_request(DHCPv4Transaction& transaction, const DHCPv4Packet& packet);

diff --git a/Userland/Services/FileSystemAccessServer/ConnectionFromClient.cpp b/Userland/Services/FileSystemAccessServer/ConnectionFromClient.cpp
@@ -26,10 +26,6 @@ ConnectionFromClient::ConnectionFromClient(NonnullOwnPtr<Core::Stream::LocalSock
  s_connections.set(1, *this);
 }
 
-ConnectionFromClient::~ConnectionFromClient()
-{
-}
-
 void ConnectionFromClient::die()
 {
  s_connections.remove(client_id());

diff --git a/Userland/Services/FileSystemAccessServer/ConnectionFromClient.h b/Userland/Services/FileSystemAccessServer/ConnectionFromClient.h
@@ -20,7 +20,7 @@ class ConnectionFromClient final
  C_OBJECT(ConnectionFromClient);
 
 public:
- ~ConnectionFromClient() override;
+ ~ConnectionFromClient() override = default;
 
  virtual void die() override;
 

diff --git a/Userland/Services/ImageDecoder/ConnectionFromClient.cpp b/Userland/Services/ImageDecoder/ConnectionFromClient.cpp
@@ -17,10 +17,6 @@ ConnectionFromClient::ConnectionFromClient(NonnullOwnPtr<Core::Stream::LocalSock
 {
 }
 
-ConnectionFromClient::~ConnectionFromClient()
-{
-}
-
 void ConnectionFromClient::die()
 {
  Core::EventLoop::current().quit(0);

diff --git a/Userland/Services/ImageDecoder/ConnectionFromClient.h b/Userland/Services/ImageDecoder/ConnectionFromClient.h
@@ -20,7 +20,7 @@ class ConnectionFromClient final
  C_OBJECT(ConnectionFromClient);
 
 public:
- ~ConnectionFromClient() override;
+ ~ConnectionFromClient() override = default;
 
  virtual void die() override;
 

diff --git a/Userland/Services/InspectorServer/ConnectionFromClient.cpp b/Userland/Services/InspectorServer/ConnectionFromClient.cpp
@@ -18,10 +18,6 @@ ConnectionFromClient::ConnectionFromClient(NonnullOwnPtr<Core::Stream::LocalSock
  s_connections.set(client_id, *this);
 }
 
-ConnectionFromClient::~ConnectionFromClient()
-{
-}
-
 void ConnectionFromClient::die()
 {
  s_connections.remove(client_id());

diff --git a/Userland/Services/InspectorServer/ConnectionFromClient.h b/Userland/Services/InspectorServer/ConnectionFromClient.h
@@ -18,7 +18,7 @@ class ConnectionFromClient final
  C_OBJECT(ConnectionFromClient);
 
 public:
- ~ConnectionFromClient() override;
+ ~ConnectionFromClient() override = default;
 
  virtual void die() override;
 

diff --git a/Userland/Services/InspectorServer/InspectableProcess.cpp b/Userland/Services/InspectorServer/InspectableProcess.cpp
@@ -33,10 +33,6 @@ InspectableProcess::InspectableProcess(pid_t pid, NonnullOwnPtr<Core::Stream::Lo
  };
 }
 
-InspectableProcess::~InspectableProcess()
-{
-}
-
 String InspectableProcess::wait_for_response()
 {
  if (m_socket->is_eof()) {

diff --git a/Userland/Services/InspectorServer/InspectableProcess.h b/Userland/Services/InspectorServer/InspectableProcess.h
@@ -13,7 +13,7 @@ namespace InspectorServer {
 class InspectableProcess {
 public:
  InspectableProcess(pid_t, NonnullOwnPtr<Core::Stream::LocalSocket>);
- ~InspectableProcess();
+ ~InspectableProcess() = default;
 
  void send_request(JsonObject const& request);
  String wait_for_response();

diff --git a/Userland/Services/LaunchServer/ConnectionFromClient.cpp b/Userland/Services/LaunchServer/ConnectionFromClient.cpp
@@ -19,10 +19,6 @@ ConnectionFromClient::ConnectionFromClient(NonnullOwnPtr<Core::Stream::LocalSock
  s_connections.set(client_id, *this);
 }
 
-ConnectionFromClient::~ConnectionFromClient()
-{
-}
-
 void ConnectionFromClient::die()
 {
  s_connections.remove(client_id());

diff --git a/Userland/Services/LaunchServer/ConnectionFromClient.h b/Userland/Services/LaunchServer/ConnectionFromClient.h
@@ -15,7 +15,7 @@ namespace LaunchServer {
 class ConnectionFromClient final : public IPC::ConnectionFromClient<LaunchClientEndpoint, LaunchServerEndpoint> {
  C_OBJECT(ConnectionFromClient)
 public:
- ~ConnectionFromClient() override;
+ ~ConnectionFromClient() override = default;
 
  virtual void die() override;
 

diff --git a/Userland/Services/LoginServer/LoginWindow.h b/Userland/Services/LoginServer/LoginWindow.h
@@ -16,7 +16,7 @@ class LoginWindow final : public GUI::Window {
  C_OBJECT(LoginWindow);
 
 public:
- virtual ~LoginWindow() override { }
+ virtual ~LoginWindow() override = default;
 
  Function<void()> on_submit;
 

diff --git a/Userland/Services/LookupServer/ConnectionFromClient.cpp b/Userland/Services/LookupServer/ConnectionFromClient.cpp
@@ -19,10 +19,6 @@ ConnectionFromClient::ConnectionFromClient(NonnullOwnPtr<Core::Stream::LocalSock
  s_connections.set(client_id, *this);
 }
 
-ConnectionFromClient::~ConnectionFromClient()
-{
-}
-
 void ConnectionFromClient::die()
 {
  s_connections.remove(client_id());

diff --git a/Userland/Services/LookupServer/ConnectionFromClient.h b/Userland/Services/LookupServer/ConnectionFromClient.h
@@ -18,7 +18,7 @@ class ConnectionFromClient final
  C_OBJECT(ConnectionFromClient);
 
 public:
- virtual ~ConnectionFromClient() override;
+ virtual ~ConnectionFromClient() override = default;
 
  virtual void die() override;
 

diff --git a/Userland/Services/LookupServer/DNSPacket.cpp b/Userland/Services/LookupServer/DNSPacket.cpp
@@ -77,7 +77,7 @@ ByteBuffer DNSPacket::to_byte_buffer() const
 
 class [[gnu::packed]] DNSRecordWithoutName {
 public:
- DNSRecordWithoutName() { }
+ DNSRecordWithoutName() = default;
 
  u16 type() const { return m_type; }
  u16 record_class() const { return m_class; }

diff --git a/Userland/Services/LookupServer/DNSPacket.h b/Userland/Services/LookupServer/DNSPacket.h
@@ -22,7 +22,7 @@ enum class ShouldRandomizeCase {
 
 class DNSPacket {
 public:
- DNSPacket() { }
+ DNSPacket() = default;
 
  static Optional<DNSPacket> from_raw_packet(const u8*, size_t);
  ByteBuffer to_byte_buffer() const;

diff --git a/Userland/Services/NotificationServer/ConnectionFromClient.cpp b/Userland/Services/NotificationServer/ConnectionFromClient.cpp
@@ -19,10 +19,6 @@ ConnectionFromClient::ConnectionFromClient(NonnullOwnPtr<Core::Stream::LocalSock
  s_connections.set(client_id, *this);
 }
 
-ConnectionFromClient::~ConnectionFromClient()
-{
-}
-
 void ConnectionFromClient::die()
 {
  s_connections.remove(client_id());

diff --git a/Userland/Services/NotificationServer/ConnectionFromClient.h b/Userland/Services/NotificationServer/ConnectionFromClient.h
@@ -18,7 +18,7 @@ namespace NotificationServer {
 class ConnectionFromClient final : public IPC::ConnectionFromClient<NotificationClientEndpoint, NotificationServerEndpoint> {
  C_OBJECT(ConnectionFromClient)
 public:
- ~ConnectionFromClient() override;
+ ~ConnectionFromClient() override = default;
 
  virtual void die() override;
 

diff --git a/Userland/Services/NotificationServer/NotificationWindow.cpp b/Userland/Services/NotificationServer/NotificationWindow.cpp
@@ -98,10 +98,6 @@ NotificationWindow::NotificationWindow(i32 client_id, const String& text, const
  };
 }
 
-NotificationWindow::~NotificationWindow()
-{
-}
-
 RefPtr<NotificationWindow> NotificationWindow::get_window_by_id(i32 id)
 {
  auto window = s_windows.get(id);

diff --git a/Userland/Services/NotificationServer/NotificationWindow.h b/Userland/Services/NotificationServer/NotificationWindow.h
@@ -15,7 +15,7 @@ class NotificationWindow final : public GUI::Window {
  C_OBJECT(NotificationWindow);
 
 public:
- virtual ~NotificationWindow() override;
+ virtual ~NotificationWindow() override = default;
  void set_original_rect(Gfx::IntRect original_rect) { m_original_rect = original_rect; };
 
  void set_text(const String&);

diff --git a/Userland/Services/RequestServer/ConnectionFromClient.cpp b/Userland/Services/RequestServer/ConnectionFromClient.cpp
@@ -22,10 +22,6 @@ ConnectionFromClient::ConnectionFromClient(NonnullOwnPtr<Core::Stream::LocalSock
  s_connections.set(1, *this);
 }
 
-ConnectionFromClient::~ConnectionFromClient()
-{
-}
-
 void ConnectionFromClient::die()
 {
  s_connections.remove(client_id());

diff --git a/Userland/Services/RequestServer/ConnectionFromClient.h b/Userland/Services/RequestServer/ConnectionFromClient.h
@@ -19,7 +19,7 @@ class ConnectionFromClient final
  C_OBJECT(ConnectionFromClient);
 
 public:
- ~ConnectionFromClient() override;
+ ~ConnectionFromClient() override = default;
 
  virtual void die() override;
 

diff --git a/Userland/Services/RequestServer/GeminiProtocol.cpp b/Userland/Services/RequestServer/GeminiProtocol.cpp
@@ -17,10 +17,6 @@ GeminiProtocol::GeminiProtocol()
 {
 }
 
-GeminiProtocol::~GeminiProtocol()
-{
-}
-
 OwnPtr<Request> GeminiProtocol::start_request(ConnectionFromClient& client, const String&, const URL& url, const HashMap<String, String>&, ReadonlyBytes)
 {
  Gemini::GeminiRequest request;

diff --git a/Userland/Services/RequestServer/GeminiProtocol.h b/Userland/Services/RequestServer/GeminiProtocol.h
@@ -13,7 +13,7 @@ namespace RequestServer {
 class GeminiProtocol final : public Protocol {
 public:
  GeminiProtocol();
- virtual ~GeminiProtocol() override;
+ virtual ~GeminiProtocol() override = default;
 
  virtual OwnPtr<Request> start_request(ConnectionFromClient&, const String& method, const URL&, const HashMap<String, String>&, ReadonlyBytes body) override;
 };

diff --git a/Userland/Services/RequestServer/Request.cpp b/Userland/Services/RequestServer/Request.cpp
@@ -19,10 +19,6 @@ Request::Request(ConnectionFromClient& client, NonnullOwnPtr<Core::Stream::File>
 {
 }
 
-Request::~Request()
-{
-}
-
 void Request::stop()
 {
  m_client.did_finish_request({}, *this, false);