Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mid: ocf-shellfuncs: Explicitly specify $OCF_RESOURCE_INSTANCE in the p parameter for compatibility. #1848

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

HideoYamauchi
Copy link
Contributor

Hi All,

The following fixes were made in pacemaker:

For compatibility, specify the option specification explicitly.

Best Regards,
Hideo Yamauchi.

@oalbrigt
Copy link
Contributor

I dont think this makes sense. It's up to the agent to specify $OCF_RESOURCE_INSTANCE.

@oalbrigt
Copy link
Contributor

I'll ask Ken about it just to be sure I'm not missing the point here.

@HideoYamauchi
Copy link
Contributor Author

Hi Oyvind,

Okay!


If you don't have $OCF_RESOURCE_INSTANCE after the p option, you will have problems with some combinations of pacemaker and resource-agent versions.

Or are you saying it's better to specify the p option last?

${HA_SBIN_DIR}/crm_attribute $@ -p

Best Regards,
Hideo Yamauchi

@HideoYamauchi
Copy link
Contributor Author

I'll ask Ken about it just to be sure I'm not missing the point here.

All right!

Thanks!
Hideo Yamauchi.

@oalbrigt oalbrigt changed the title Mid: Explicitly specify $OCF_RESOURCE_INSTANCE in the p parameter for compatibility. Mid: ocf-shellfuncs: Explicitly specify $OCF_RESOURCE_INSTANCE in the p parameter for compatibility. Mar 13, 2023
@oalbrigt oalbrigt merged commit fe1a2f8 into ClusterLabs:main Mar 13, 2023
@oalbrigt
Copy link
Contributor

Thanks. Ken confirmed this solves the issue for 2.1.0-2.1.5.

@HideoYamauchi
Copy link
Contributor Author

Thanks. Ken confirmed this solves the issue for 2.1.0-2.1.5.

OKay!

Many thanks,
Hideo Yamauchi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants