Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lvmlockd: add "use_lvmlockd = 1" if it's commented out or missing #1824

Merged
merged 1 commit into from
Dec 1, 2022
Merged

lvmlockd: add "use_lvmlockd = 1" if it's commented out or missing #1824

merged 1 commit into from
Dec 1, 2022

Conversation

oalbrigt
Copy link
Contributor

@oalbrigt oalbrigt commented Dec 1, 2022

No description provided.

zhaohem
zhaohem reviewed Dec 1, 2022
View reviewed changes
Copy link
Contributor

@zhaohem zhaohem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this patch LGTM.

@zzhou1
Copy link
Contributor

zzhou1 commented Dec 1, 2022

Wonderful, and very quick fix !

Minor comment for the commit log, ideally, adding the following link would make the tracking record perfect ;)

REF: https://bugzilla.redhat.com/show_bug.cgi?id=2086889

@oalbrigt oalbrigt force-pushed the lvmlockd-add-use_lvmlockd-if-missing branch from 06bb5e9 to 2695888 Compare December 1, 2022 10:20
@oalbrigt oalbrigt merged commit 3e84b0b into ClusterLabs:main Dec 1, 2022
@oalbrigt oalbrigt deleted the lvmlockd-add-use_lvmlockd-if-missing branch December 1, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaohem zhaohem zhaohem left review comments

@zzhou1 zzhou1 zzhou1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oalbrigt @zzhou1 @zhaohem