Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop 'black' for 'ruff format' in CI #271

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Drop 'black' for 'ruff format' in CI #271

merged 4 commits into from
Jun 4, 2024

Conversation

brews
Copy link
Member

@brews brews commented May 31, 2024

This completes replacing black with ruff for linting and format checks in CI and dropping black entirely as a requirement from the package.

Few people will notice the change unless they're looking at PRs and results from CI.

Ruff asked for a minor code clean up, so that's in here, too.

@brews brews added the enhancement New feature or request label May 31, 2024
@brews brews self-assigned this May 31, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.91%. Comparing base (0246464) to head (97cb51c).

Files Patch % Lines
src/dscim/utils/rff.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #271   +/-   ##
=======================================
  Coverage   68.91%   68.91%           
=======================================
  Files          15       15           
  Lines        1750     1750           
=======================================
  Hits         1206     1206           
  Misses        544      544           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brews brews changed the title Drop 'black' for 'ruff format' in CI. Drop 'black' for 'ruff format' in CI May 31, 2024
@brews brews requested a review from kemccusker May 31, 2024 05:25
@brews
Copy link
Member Author

brews commented May 31, 2024

@kemccusker I'm marking you as a reviewer as a heads-up about this change. Things might look a bit different, but it's running the same kind of thing, just faster and with one less dependency.

@brews
Copy link
Member Author

brews commented May 31, 2024

Codecov is giving this the ❌ because it does a minor format change on lines that have no code coverage. Good thing to raise but I'm pretty sure it's okay.

Copy link
Member

@kemccusker kemccusker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me, @brews, I trust you on this

@kemccusker kemccusker merged commit 08b6e02 into main Jun 4, 2024
3 of 4 checks passed
@kemccusker kemccusker deleted the drop_black branch June 4, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants