Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing saving post-processing Ag damages #69

Closed
davidrzhdu opened this issue Feb 10, 2023 · 0 comments
Closed

Failing saving post-processing Ag damages #69

davidrzhdu opened this issue Feb 10, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@davidrzhdu
Copy link
Contributor

dscim/src/dscim/preprocessing/input_damages.py

Lines 388 to 390 in bad6c0e

batches.rename({"wc_reallocation": varname})[varname].to_zarr(
save_path, mode="a", consolidated=True
)

'DataArray' object cannot be saved as a .zarr file directly, needs to be turned into a "Dataset" first. This is a potential bug.
@davidrzhdu davidrzhdu added the bug Something isn't working label Feb 10, 2023
@kemccusker kemccusker mentioned this issue Mar 2, 2023
Merged
kemccusker added a commit that referenced this issue Mar 2, 2023
@kemccusker
Merge pull request #72 from ClimateImpactLab/69-failing-saving-post-p…
cca3ddb 
…rocessing-ag-damages

Fix saving bug in compute_ag_damages() (Issue #69 )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

69-failing-saving-post-processing-ag-damages ClimateImpactLab/dscim
1 participant
@davidrzhdu