Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused args and parameters in dscim.utils.utils.model_outputs()? #42

Closed
brews opened this issue Sep 16, 2022 · 1 comment
Closed

Unused args and parameters in dscim.utils.utils.model_outputs()? #42

brews opened this issue Sep 16, 2022 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists help wanted Extra attention is needed

Comments

@brews
Copy link
Member

brews commented Sep 16, 2022

def model_outputs(

dscim.utils.utils.model_outputs() takes arguments "extrap_formula" and "extrap_year" but these appear to be unused. Similarly, extrap_exog are defined a couple of times but unused in the code.

Note I think this is related to #15, because all these variables are used behind the block of code behind where the NotImplementedError is raised (it's weird, but see #15).

@brews brews added bug Something isn't working help wanted Extra attention is needed labels Sep 16, 2022
@brews
Copy link
Member Author

brews commented Sep 16, 2022

I'm marking this as "duplicate" and closing. This is the same issue as in #15 so we'll deal with it there.

@brews brews closed this as not planned Won't fix, can't repro, duplicate, stale Sep 16, 2022
@brews brews added the duplicate This issue or pull request already exists label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant