Large code block in dscim.utils.utils.model_outputs will never run

[brews]

There is a large block of code in dscim.utils.utils.model_outputs() when using "time_trends" extrapolation that doesn't run because it is behind a raised NotImplementedError. This chunk of code feels like it might just have bad indentation...? I'm not sure what the desired behavior is.

The NotImplementedError blocking the rest of the function is here:

dscim/src/dscim/utils/utils.py

Line 439 in 8a870c3

raise NotImplementedError(

[brews]

To avoid problems, I'm closing #42 and consolidating the issue here.

dscim.utils.utils.model_outputs() takes arguments extrap_formula and extrap_year but these appear to be unused. Similarly, extrap_exog is defined a couple of times but unused in the code because of the above block.

In short: If we remove this never-running block of code, we should also clean up extrap_formula, extrap_year, and extrap_exog.

[kemccusker]

I think that

dscim/src/dscim/utils/utils.py

Line 437 in 8a870c3

if extrapolation_type == "time_trends":

is checking a possibly unused or outdated method option ("time_trends") that we played around with in the early days of dscim and then scrapped. But didn't remove the option here. Would need to confirm that by doing some archeology before deleting the code-block.

[brews]

This closed with #53.