Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert_old_to_newformat_AR()'s "pulseyrs" arg has a mutable default #31

Closed
brews opened this issue Sep 15, 2022 · 3 comments · Fixed by #51
Closed

convert_old_to_newformat_AR()'s "pulseyrs" arg has a mutable default #31

brews opened this issue Sep 15, 2022 · 3 comments · Fixed by #51
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@brews
Copy link
Member

brews commented Sep 15, 2022

dscim.preprocessing.climate.reformat.convert_old_to_newformat_AR() has a mutable default arg ("pulseyrs").

This is a common gotcha, we might want to refactor this to avoid bugs.

dscim/src/dscim/preprocessing/climate/reformat.py

Line 8 in 8a870c3

def convert_old_to_newformat_AR(

@brews brews added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Sep 15, 2022
@brews
Copy link
Member Author

brews commented Sep 16, 2022

🤔 Now that I look at it more closely, this "pulseyrs" arg is completely unused. Might just remove it all together.

@davidrzhdu
Copy link
Contributor

Agree, "pulseyrs" is not used.

davidrzhdu added a commit that referenced this issue Sep 27, 2022
@davidrzhdu
Fix issue #31
cbaa19c
@kemccusker kemccusker mentioned this issue Sep 27, 2022
Merged
kemccusker added a commit that referenced this issue Sep 29, 2022
@kemccusker
Merge pull request #51 from ClimateImpactLab/issue_fixes
440ee27 
Issue fixes (#39 and #31)
@brews
Copy link
Member Author

brews commented Sep 29, 2022

This was fixed with PR #51 but didn't autoclose. Closing.

@brews brews closed this as completed Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue fixes (#39 and #31) ClimateImpactLab/dscim
2 participants
@brews @davidrzhdu