Custom ClickHouse Schema changes #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: These schema changes are committed in the simplest possible way so that we can ship something to core team which will allow them to use the product. After shipping this, we will rewrite the code such that the columns which are pulled out from the resource attributes are configurable - so that we may then push a PR to the upstream community branch. There is no intention that these changes remain as a fork on top of the upstream branch. Please consider this when reviewing.
|
|
RoryCrispin
added a commit
that referenced
this pull request
May 15, 2023
* Custom ClickHouse Schema changes NOTE: These schema changes are committed in the simplest possible way so that we can ship something to core team which will allow them to use the product. After shipping this, we will rewrite the code such that the columns which are pulled out from the resource attributes are configurable - so that we may then push a PR to the upstream community branch. There is no intention that these changes remain as a fork on top of the upstream branch. Please consider this when reviewing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewers
These schema changes are committed in the simplest possible way so that we can ship something to core team which will allow them to use the product.
After shipping this, we will rewrite the code such that the columns which are pulled out from the resource attributes are configurable - so that we may then push a PR to the upstream community branch.
There is no intention that these changes remain as a fork on top of the upstream branch.
Follow up with: https://github.com/ClickHouse/data-plane-application/issues/4156
Closes: https://github.com/ClickHouse/data-plane-application/issues/4038