Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Adding more attunement spells (3/3) #49811

Merged
merged 24 commits into from
Aug 7, 2021
Merged

[Magiclysm] Adding more attunement spells (3/3) #49811

merged 24 commits into from
Aug 7, 2021

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Jul 10, 2021

Summary

Mods "Adding more attunement spells"

Purpose of change

Adding:
Wither mage "Life drain" spell (low damage stamina stealing attack)
Vulcanist "Pyroclastic flow" (high damage AoE spell)
Void mage "Final Grasp" spell (middle damage stopping dot)
Void mage "Horizon Vortex" spell (unmissable AoE with random damage) (and a lot of his subspell)
Alchemist "Manafusion bomb" ("magic" grenade from potion_starter) + grenade recipe for it
Alchemist "Manafusion trap" ("magic" landmine from manafusion bombs)
I planned to add spell to convert water to potion_starter, but it create water right in your hand, and it just spill to ground
Renamed Aura mage to Alchemist

Testing

I didnt test it yet, cause i did it a long time ago, but ill test if in few hours tested

Additional context

Some of the changes that was maded by maintainers were lost, like some descriptions errors (sorry for that), so i hope someone can check them and some stuff that was added after content freeze that i didnt notice.
Also its not linted yet. linted

@ZhilkinSerg ZhilkinSerg added the Mods: Magiclysm Anything to do with the Magiclysm mod label Jul 10, 2021
@GuardianDll GuardianDll marked this pull request as ready for review July 10, 2021 21:18
@actual-nh
Copy link
Contributor

actual-nh commented Jul 12, 2021

The test failure isn't from this change. It's a random margin thing:

    // Need a pretty big margin here, it's fairly random
    // Just make sure that not everone lives and not everyone dies

The result needed to be within 25 of 50. It was 26 away.

Copy link
Contributor

@actual-nh actual-nh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definite progress!

data/mods/Magiclysm/Spells/attunements/Alchemist.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/Spells/attunements/Alchemist.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/Spells/attunements/Void_Mage.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/Spells/attunements/Void_Mage.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/Spells/attunements/Void_Mage.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/Spells/attunements/Void_Mage.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/items/alchemy_items.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/items/alchemy_items.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/items/alchemy_items.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/items/alchemy_items.json Outdated Show resolved Hide resolved
Copy link
Contributor

@actual-nh actual-nh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manabomb/trap components.

data/mods/Magiclysm/items/alchemy_items.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/items/alchemy_items.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/items/alchemy_items.json Outdated Show resolved Hide resolved
Copy link
Contributor

@actual-nh actual-nh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few that seem to have gotten lost.

data/mods/Magiclysm/Spells/attunements/Alchemist.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/Spells/attunements/Alchemist.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/Spells/attunements/Void_Mage.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/Spells/attunements/Void_Mage.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/items/alchemy_items.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/items/alchemy_items.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/items/alchemy_items.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/items/alchemy_items.json Outdated Show resolved Hide resolved
@GuardianDll GuardianDll marked this pull request as draft July 24, 2021 18:15
@GuardianDll
Copy link
Member Author

make it draft cause it still need some rewriting

@GuardianDll GuardianDll marked this pull request as ready for review July 26, 2021 03:00
@GuardianDll
Copy link
Member Author

Yep, i thought about rewriting the alchemist spell, but of course it doesnt work in this case

Comment on lines +14 to +16
"min_damage": 1,
"max_damage": 3,
"damage_increment": 0.07,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the point in these numbers? you have 10,000 stamina when your stamina bar is full

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, its for spawning more than 1 bomb using wonder mechanic (3 bombs at max)

"name": "Manafusion bomb",
"description": "Oversaturates potion starter with mana to create a deadly mana explosion.",
"valid_targets": [ "none" ],
"flags": [ "SOMATIC", "WONDER" ],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder? i don't think so

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder is for spawning more than 1 bomb per cast

"description": "Make a manafusion trap, stabilizing manafusion bombs and giving you some of the excess mana.",
"//": "In perfect world there will be another spell that create already buried mine, making very effective trap in realtime. But not today.",
"valid_targets": [ "none" ],
"flags": [ "SOMATIC", "WONDER" ],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Comment on lines +54 to +56
"min_damage": 1,
"max_damage": 3,
"damage_increment": 0.07,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above. if you really wanted this to be a placeholder it should have been an attack spell that does 0 damage...

"shape": "blast",
"max_level": 35,
"min_damage": -100,
"max_damage": -3000,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

30 seconds of a completely frozen enemy seems a bit extreme, doesn't it?

Copy link
Member Author

@GuardianDll GuardianDll Aug 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for an attunement spell, on max level (its a bit lesser than 20 second on 20 lvl), and for one target - i dont think so, but i can reduce it if its necessary

"valid_targets": [ "hostile", "ground", "ally" ],
"damage_type": "heat",
"max_level": 35,
"difficulty": 10,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i noticed all of your spells are very high difficulty and was wondering if you thought they needed to be high difficulty because they were attunement spells.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in my tests the high magic skill and intelligence gradually reduce spell difficulty, so 5 lvl spell with difficulty 9 has 60% of fail on 5 magic level and 6 intelligence (which is pretty easy to get for endgame spells) (+1 magic skill level decrease it on 8%, when +1 intelligence decrease it on 30% ). in summary i think its not so big deal for so high level spells on the moment people can get them

Copy link
Member

@KorGgenT KorGgenT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that need to be made, and perhaps some (light) examination of the balance of a few of them, but I rather like horizon vortex a lot. Shouldn't be too hard to adjust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mods: Magiclysm Anything to do with the Magiclysm mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants