This repository has been archived by the owner on Dec 27, 2019. It is now read-only.
New ssh permissions strategy. #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fionawhim
reviewed
Jun 11, 2018
scripts/init-docker-container.sh
Outdated
| @@ -23,6 +23,9 @@ do | |||
| ln -s "/host-repo/${p}" "./${p}" | |||
| done | |||
|
|
|||
| # Uncomment next line to copy files in mounted ssh folder from host into container to ensure root:root permissions. | |||
| # cp -rfu ~/host-ssh/ ~/.ssh/ | |||
There was a problem hiding this comment.
Wouldn’t this happen automatically by the build:local steps below?
There was a problem hiding this comment.
Yes. It gets done in the local:sync just before each time we sync the database. But if we don't want it to run each time we sync, then the best place to do it is here.
There was a problem hiding this comment.
Remember that if you’re running this script, the build:local commands below will completely reset your database, destroying anything that was synced in.
If you want to run this separately from ./task.sh commands I’d recommend either noting it as a one-liner in README.md that you can run after bashing in, or add it to the doit script like some of the logging commands.
|
Approved! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes [insert bug/issue number]
Adhoc Development Changes
Changes proposed in this pull request:
Add @mentions of the person or team responsible for reviewing proposed changes
@jimafisk @finneganh