Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export docker image types #164

Merged
merged 2 commits into from
Nov 17, 2022
Merged

fix: export docker image types #164

merged 2 commits into from
Nov 17, 2022

Conversation

Jaryt
Copy link
Contributor

@Jaryt Jaryt commented Nov 16, 2022

Export the contents of DockerImage.ts from types.executors.docker.

Fixes #163

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 96.15% // Head: 96.16% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (00c8e70) compared to base (137e014).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 00c8e70 differs from pull request most recent head d06948e. Consider uploading reports for the commit d06948e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   96.15%   96.16%   +0.01%     
==========================================
  Files          61       62       +1     
  Lines         676      678       +2     
  Branches       69       69              
==========================================
+ Hits          650      652       +2     
  Misses         11       11              
  Partials       15       15              
Impacted Files Coverage Δ
...Components/Executors/types/DockerExecutor.types.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ghost
Copy link

ghost commented Nov 16, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@KyleTryon KyleTryon merged commit 79e0b77 into main Nov 17, 2022
@KyleTryon KyleTryon deleted the fix/export-docker-image branch November 17, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants