Detekt to 1.7.4

[cortinico]

📄 Context

Let's update Detekt before #298

📝 Changes

Seems like our detekt configuration was still using an older version (1.4.0). I've extracted that versions to use the version defined at the top level (same for `ktlint).

⏱️ Next steps

I've re-gerated the config file with ./gradlew detektGenerateConfig. I've also copied over as we can potentially turn on more rules that are currently disabled by default.

[vbuberen]

Quite an extensive amount of rules here.
Just minor changes required.

[cortinico]

Answering here for all the comments. What I added is the default Detekt config file. I had to add it as I removed the buildUponDefaultConfig flag.

If we start customising it extensively (e.g. removing all the Spec exclusions, etc.), we will have to manually re-apply those changes whenever we regenerate the default config file (with newer rules, etc.).

If you wish, I can also revert to use the buildUponDefaultConfig flag and just have our customisation. It's just a bit harder to discover new rules, but not a big deal.

[vbuberen]

I thought you want to be able to do a in-depth customisation and decided to add such default file.
If we are not going to change this default config file when I would just revert to our previous approach, since there is no sense in keeping it.

[cortinico]

I thought you want to be able to do a in-depth customisation and decided to add such default file.

Yeah that was the idea. But I wanted to do this in a incremental way, like in one or more subsequent PRs as I don't know how many Rules failure I have to fix once I start enabling them.

[cortinico]

Anyway if you wish we can also take the buildUponDefaultConfig approach and keep only our customisation.

[vbuberen]

Let's do these incremental changes after releasing 3.2.0 and just merge the update now with old way of configuration.

[vbuberen]

LGTM 🚢